Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std: Ignore a flaky test on Android #49047

Closed
wants to merge 1 commit into from
Closed

std: Ignore a flaky test on Android #49047

wants to merge 1 commit into from

Conversation

alexcrichton
Copy link
Member

I don't think we're getting much benefit from having a flaky test fail on us
every now and then. Unfortunately it seems like we have no idea why this is
flaky and infinitely blocking sometimes, so let's ignore it for now on Android
but continue to run it on other platforms.

cc #43283

@alexcrichton
std: Ignore a flaky test on Android
c6d9552 
I don't think we're getting much benefit from having a flaky test fail on us
every now and then. Unfortunately it seems like we have no idea why this is
flaky and infinitely blocking sometimes, so let's ignore it for now on Android
but continue to run it on other platforms.

cc rust-lang#43283
@rust-highfive
Copy link
Collaborator

r? @bluss

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 15, 2018
@alexcrichton
Copy link
Member Author

r? @kennytm

@rust-highfive rust-highfive assigned kennytm and unassigned bluss Mar 15, 2018
@kennytm
Copy link
Member

kennytm commented Mar 15, 2018

I suspect this is due to read2() blocking and can be fixed by using the implementation in rust-lang/cargo#5030 (i.e. #48165) instead.

In libstd's read2() when we exhausted stderr, we will turn stdout into blocking mode and read the rest immediately (and vice-versa). Maybe Android's custom libc is buggy here (e.g. maybe stdout is empty and closed but read() never returns).

In contrast, Cargo's read2() will never change the blocking mode of these two files, it just stops polling the EOF'ed file. (BTW I'm pretty sure Cargo's read2()'s comment about blocking mode is outdated.)

I'd prefer trying this over ignoring the test.

@alexcrichton
Copy link
Member Author

Ah ok. I don't really know what to be concerned about here unfortunately. I left the test running in a loop all day on my computer and it never failed, and I'd prefer to not guess too much about libc bugs. In any case it's not too much of a nuisance, so I'll close.

@alexcrichton alexcrichton deleted the ignore-failing-android-test branch June 29, 2018 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kennytm kennytm

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexcrichton @rust-highfive @kennytm @bluss